hack/ci: do not swallow apiv2 failures - #29528
Conversation
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Seems to be errors during dlopen, obviously we cannot merge this when the tests fail. Unfortunately the lib does not log the error message from dlopen. One thing I do not get why does this only fail as rootless but not root? |
|
@Luap99 dug at the rootless/root bit. same run, the two apiv2 jobs: and it started on a specific main run, both ran the full bash suite so its not a truncated one: AUTOMATION_RELEASE is 20260722t094115z on both sides so not an image bump, and the only commit in between touches userns inspect and adds 6 apiv2 cases, nothing journald. so I couldnt pin it on either. no idea on why root loads the same libsystemd fine. I only have the mac client here so I cant reproduce it. agreed it cant merge while they fail, happy to leave it open or close and redo once they are sorted. |
lets keep it open, it is important enough so we do not introduce new errors. I will try to see what is going on with dlopen here |
|
@Luap99 on the dlopen message - if you point a |
The apiv2 bash suite has not gated CI since 66c6da6.
run_apiv2puts both make targets inside onesh -c "( ... )"with noset -e, so only the last command decides the exit status andmake localapiv2-bashis discarded.set -eo pipefailat the top of runner.sh is the outer bash and does not reach into that innersh.It is failing right now on main. Run 31847250452, job
apiv2 rootless fedora-current, conclusion success, log line 3089:Same thing in the three earlier green main runs I checked (31687097967, 31540756565, 31514570842), each with plan
1..2191andError 17.I used an accumulator rather than
set -eso the python half still runs when the bash half fails - otherwise we would lose that half of the report on every failure. Checked the shapes on bash 5.2: the current one exits 0 when the first target fails, this one exits 1 and still runs both.I have not looked into the 17 failures themselves yet, they look like three clusters in 26-containersWait and 27-containersEvents. Happy to open a separate issue for those once this gates again.